ffi: fix optimized buffer conversions by trivikr · Pull Request #64639 · nodejs/node

trivikr · 2026-07-21T03:43:06Z

Fast FFI calls with buffer or arraybuffer argument signatures accepted pointer-like values through the generic path, but rejected non-memory-backed values after optimization.

This change keeps the primary optimized entry point compatible with raw pointer conversions while retaining the specialized native fast path for memory-backed arguments. Optimized calls now consistently accept documented representations including bigint, strings, nullish values, buffers, typed arrays, and ArrayBuffer objects.

Assisted-by: openai:gpt-5.6-sol

nodejs-github-bot · 2026-07-21T03:43:11Z

Review requested:

@nodejs/ffi

codecov · 2026-07-21T06:06:10Z

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (e7904d4) to head (9e1a804).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/ffi/fast-api.js	62.50%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #64639      +/-   ##
==========================================
- Coverage   90.14%   90.14%   -0.01%     
==========================================
  Files         746      746              
  Lines      242764   242741      -23     
  Branches    45739    45735       -4     
==========================================
- Hits       218848   218819      -29     
+ Misses      15426    15422       -4     
- Partials     8490     8500      +10

Files with missing lines	Coverage Δ
lib/ffi.js	`94.92% <ø> (-0.04%)`	⬇️
src/ffi/fast.cc	`68.13% <100.00%> (+1.46%)`	⬆️
src/ffi/fast.h	`100.00% <ø> (ø)`
src/node_ffi.cc	`71.12% <100.00%> (+0.03%)`	⬆️
lib/internal/ffi/fast-api.js	`82.53% <62.50%> (-1.86%)`	⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-07-27T23:05:09Z

This PR will be rebased and made ready for review after the fix in ppc64 lands in #64792

Preserve pointer-like argument conversions for buffer and arraybuffer signatures after Fast API optimization. Keep memory-backed arguments on the specialized native fast path. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol

trivikr · 2026-07-30T04:29:32Z

@ShogunPanda @avivkeller Can one of you please provide your approval again?
The bug which was causing tests to fail was fixed in #64792, and this PR was rebased.

nodejs-github-bot · 2026-07-30T04:42:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75302/

nodejs-github-bot · 2026-07-30T17:52:14Z

Commit Queue failed

- Loading data for nodejs/node/pull/64639
✔  Done loading data for nodejs/node/pull/64639
----------------------------------- PR info ------------------------------------
Title      ffi: fix optimized buffer conversions (#64639)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     trivikr:ffi-buffer-sig-bigint -> nodejs:main
Labels     c++, lib / src, needs-ci, ffi
Commits    1
 - ffi: fix optimized buffer conversions
Committers 1
 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64639
Fixes: https://github.com/nodejs/node/issues/64638
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64639
Fixes: https://github.com/nodejs/node/issues/64638
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 21 Jul 2026 03:43:06 GMT
   ✔  Approvals: 2
   ✔  - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/64639#pullrequestreview-4819398365
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64639#pullrequestreview-4783382497
   ✘  2 GitHub CI job(s) cancelled:
   ✘    - lint-readme: CANCELLED (https://github.com/nodejs/node/actions/runs/30509655206/job/90766758617)
   ✘    - lint-pr-url: CANCELLED (https://github.com/nodejs/node/actions/runs/30509655206/job/90766758661)
   ℹ  Last Full PR CI on 2026-07-30T04:42:36Z: https://ci.nodejs.org/job/node-test-pull-request/75302/
- Querying data for job/node-test-pull-request/75302/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/30567472928

nodejs-github-bot · 2026-07-30T18:57:49Z

Landed in f85fdab

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2026

ShogunPanda approved these changes Jul 21, 2026

View reviewed changes

trivikr added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 21, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2026

This comment was marked as outdated.

Sign in to view

trivikr force-pushed the ffi-buffer-sig-bigint branch 2 times, most recently from 139053a to d4a75ce Compare July 23, 2026 15:47

trivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 23, 2026

This comment was marked as outdated.

Sign in to view

trivikr added request-ci Add this label to start a Jenkins CI on a PR. ffi Issues and PRs related to experimental Foreign Function Interface support. labels Jul 23, 2026

trivikr force-pushed the ffi-buffer-sig-bigint branch from d4a75ce to c2e566c Compare July 27, 2026 01:11

avivkeller approved these changes Jul 27, 2026

View reviewed changes

trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 27, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2026

This comment was marked as outdated.

Sign in to view

trivikr marked this pull request as draft July 27, 2026 18:46

trivikr mentioned this pull request Jul 27, 2026

ffi: preserve link register in ppc64 trampoline #64792

Merged

This comment was marked as outdated.

Sign in to view

trivikr force-pushed the ffi-buffer-sig-bigint branch from 700494d to 9e1a804 Compare July 30, 2026 02:52

trivikr marked this pull request as ready for review July 30, 2026 02:53

trivikr added request-ci Add this label to start a Jenkins CI on a PR. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 30, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2026

ShogunPanda approved these changes Jul 30, 2026

View reviewed changes

trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 30, 2026

trivikr added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 30, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2026

nodejs-github-bot merged commit f85fdab into nodejs:main Jul 30, 2026
107 of 109 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ffi: fix optimized buffer conversions - #64639

ffi: fix optimized buffer conversions#64639
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:ffi-buffer-sig-bigint

trivikr commented Jul 21, 2026

Uh oh!

nodejs-github-bot commented Jul 21, 2026

Uh oh!

This comment was marked as outdated.

codecov Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

trivikr commented Jul 27, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

trivikr commented Jul 30, 2026

Uh oh!

nodejs-github-bot commented Jul 30, 2026

Uh oh!

nodejs-github-bot commented Jul 30, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

trivikr commented Jul 21, 2026

Uh oh!

nodejs-github-bot commented Jul 21, 2026

Uh oh!

This comment was marked as outdated.

codecov Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

trivikr commented Jul 27, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

trivikr commented Jul 30, 2026

Uh oh!

nodejs-github-bot commented Jul 30, 2026

Uh oh!

nodejs-github-bot commented Jul 30, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jul 21, 2026 •

edited

Loading