.Net: Fix GeminiPromptExecutionSettings.Clone dropping Labels and CachedContent - #14194
Open
dfedoryshchev wants to merge 1 commit into
Open
.Net: Fix GeminiPromptExecutionSettings.Clone dropping Labels and CachedContent#14194dfedoryshchev wants to merge 1 commit into
dfedoryshchev wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a correctness issue in the .NET Google Gemini connector where GeminiPromptExecutionSettings.Clone() previously dropped two serialized, user-settable properties (Labels and CachedContent), causing cloned settings to lose request metadata and explicit caching references.
Changes:
- Update
GeminiPromptExecutionSettings.Clone()to cloneLabels(as a new dictionary) and copyCachedContent. - Extend
PromptExecutionSettingsCloneWorksAsExpectedunit test to set and assert bothlabelsandcached_contentsurvive cloning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs | Ensures Clone() preserves Labels and CachedContent (previously omitted). |
| dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs | Adds assertions verifying the new clone behavior for Labels and CachedContent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
GeminiPromptExecutionSettings.Clone()rebuilds the settings through an object initializer, but two settable, serialized properties are missing from it, so cloning silently drops them:Labels([JsonPropertyName("labels")])CachedContent([JsonPropertyName("cached_content")])Every other serialized property is copied in
Clone(); these two are not, so a clone loses the request labels and the explicit-cache reference.Description
Labels(as a new dictionary, matching howExtensionData/StopSequencesare cloned) andCachedContentinClone().PromptExecutionSettingsCloneWorksAsExpectedto set and assert both properties.Contribution Checklist